Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor selection styling #468

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Chore: refactor selection styling #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa95c98
chore: refactor the styling of selection and hovering in TreeMode (WIP)
josdejong Jul 23, 2024
b97ce39
fix: background when hovering selected keys and values
josdejong Jul 23, 2024
b82aec3
fix: selection background color when editing
josdejong Jul 23, 2024
5a0572d
chore: refactor :global cases for ContextMenuPointer styling into com…
josdejong Jul 23, 2024
06a01a4
chore: use `JSONValue` in `TableMode`, remove `JSONValueCell`
josdejong Jul 23, 2024
5c5deac
fix: deleting a table cell broken
josdejong Jul 23, 2024
2bd9d6f
chore: update test snapshots
josdejong Jul 23, 2024
38f2934
feat: extend `JSONEditorContext` with a property `mode`, and remove s…
josdejong Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/components/JSONEditor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
display: flex;
flex-direction: row;

&.jse-focus {
// lighter selection color when the editor doesn't have focus
&:not(.jse-focus) {
--jse-selection-background-color: #{$selection-background-inactive-color};
--jse-context-menu-pointer-background: #{$context-menu-pointer-hover-background};
}
}
Loading