fix: maintain the enforceString status after replacing a value

josdejong · May 23, 2022 · 4d1e9e3 · 4d1e9e3
1 parent ef09810
commit 4d1e9e3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/lib/logic/documentState.js b/src/lib/logic/documentState.js
@@ -506,7 +506,7 @@ export function documentStatePatch(json, state, operations) {
     }
   }
 
-  function after(state, operation) {
+  function after(state, operation, previousState) {
     const { op, path } = operation
 
     let updatedState = state
@@ -518,6 +518,14 @@ export function documentStatePatch(json, state, operations) {
       }
     }
 
+    if (op === 'replace') {
+      // copy the old enforceString state after replacing a value
+      const enforceString = getIn(previousState, path.concat([STATE_ENFORCE_STRING]))
+      if (typeof enforceString === 'boolean') {
+        updatedState = setIn(updatedState, path.concat([STATE_ENFORCE_STRING]), enforceString)
+      }
+    }
+
     return updatedState
   }
 

diff --git a/src/lib/logic/documentState.test.js b/src/lib/logic/documentState.test.js
@@ -545,6 +545,16 @@ describe('documentState', () => {
       assert.strictEqual(typeof updatedState.c[STATE_ID], 'string')
     })
 
+    it('replace: should keep enforceString state', () => {
+      const json = '42'
+      const state = syncState(json, undefined, [], () => false)
+      assert.strictEqual(state[STATE_ENFORCE_STRING], true)
+
+      const operations = [{ op: 'replace', path: '', value: 'forty two' }]
+      const updatedState = documentStatePatch(json, state, operations).state
+      assert.deepStrictEqual(updatedState[STATE_ENFORCE_STRING], true)
+    })
+
     it('add: should override a value in an object', () => {
       // TODO
     })