fix: paste as JSON helper message not working

josdejong · May 20, 2022 · 0f803b2 · 0f803b2
1 parent 9bd28db
commit 0f803b2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/lib/components/controls/Message.svelte b/src/lib/components/controls/Message.svelte
@@ -28,6 +28,7 @@
       <button
         type="button"
         on:click={action.onClick}
+        on:mousedown={action.onMouseDown}
         class="jse-button jse-action jse-primary"
         title={action.title}
         disabled={action.disabled}

diff --git a/src/lib/components/modes/treemode/TreeMode.svelte b/src/lib/components/modes/treemode/TreeMode.svelte
@@ -1968,6 +1968,7 @@
   }
 
   async function handleParsePastedJson() {
+    debug('apply pasted json', pastedJson)
     const { path, contents } = pastedJson
 
     // exit edit mode
@@ -1995,6 +1996,7 @@
   }
 
   function handleClearPastedJson() {
+    debug('clear pasted json')
     pastedJson = undefined
   }
 
@@ -2184,7 +2186,11 @@
             {
               icon: faWrench,
               text: 'Paste as JSON instead',
-              onClick: handleParsePastedJson
+              // We use mousedown here instead of click: this message pops up
+              // whilst the user is editing a value. When clicking this button,
+              // the actual value is applied and the event is not propagated
+              // and an onClick on this button never happens.
+              onMouseDown: handleParsePastedJson
             },
             {
               text: 'Leave as is',