Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

fails with 404 #9

Closed
davidkarlsen opened this issue Jul 19, 2020 · 2 comments · Fixed by #12
Closed

fails with 404 #9

davidkarlsen opened this issue Jul 19, 2020 · 2 comments · Fixed by #12
Labels
bug Something isn't working
Milestone
2.2.0

Comments

@davidkarlsen
Copy link 

Run joschi/setup-jdk@v2.1.0
  with:
    java-version: openjdk14
    release_type: ga
    java-package: jdk
    openjdk_impl: hotspot
    architecture: x64
    heap_size: normal
    release: latest
##[error]Unexpected HTTP response: 404

joschi/setup-jdk@v2.1.0 fails, joschi/setup-jdk@v1 works
@davidkarlsen
Copy link
Author

ah - nvm - there was an updated syntax.

@joschi
Copy link
Owner

joschi commented Jul 19, 2020 •
edited
Loading

@davidkarlsen Thanks for reporting this!

setup-jdk 2.x should have been compatible with version 1.x, so I consider this a bug. 😃

@joschi joschi reopened this Jul 19, 2020
@joschi joschi added the bug Something isn't working label Jul 19, 2020
joschi added a commit that referenced this issue Jul 20, 2020
@joschi
Restore compatibility with joschi/setup-jdk@v1 for java-version
eea40c6 
The normalization of the `java-version` setting to treat "openjdk14" as
a valid Java release version was accidentally dropped while moving to
joschi/setup-jdk 2.x.

Closes #9
@joschi joschi mentioned this issue Jul 20, 2020
Merged
@joschi joschi added this to the 2.2.0 milestone Jul 20, 2020
joschi added a commit that referenced this issue Jul 20, 2020
@joschi
Restore compatibility with joschi/setup-jdk@v1 for java-version (#12)
e1f4ee7 
The normalization of the `java-version` setting to treat "openjdk14" as a valid Java release version was accidentally dropped while moving to joschi/setup-jdk 2.x.

Closes #9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Restore compatibility with joschi/setup-jdk@v1 for java-version joschi/setup-jdk
2 participants
@davidkarlsen @joschi