New Rule: body-match-regex #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body-match-regex rule allows users to enforce that the commit-msg body matches a given regex. Closes #130
keestux
reviewed
Feb 24, 2025
|
|
||
| # Ensure body contains the word "Foo" somewhere | ||
| [body-match-regex] | ||
| regex=(*.)Foo(.*) |
There was a problem hiding this comment.
The example has two problems.
- the prefix should be
(.*) - the prefix and postfix are totally unnecessary. The Python code is doing a
searchso the(.*)isn't going to make a difference
I suppose it would make more sense to match the word Foo (and not Foolish) as follows:
# Ensure body contains the word "Foo" somewhere in the body
[body-match-regex]
regex=\bFoo\b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body-match-regex rule allows users to enforce that the commit-msg
body matches a given regex.
Closes #130