Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use install-hooks in with git worktree #68

Closed
jpulec opened this issue Jun 21, 2018 · 2 comments
Closed

Can't use install-hooks in with git worktree #68

jpulec opened this issue Jun 21, 2018 · 2 comments
Labels
enhancement User-facing feature enhancements

Comments

@jpulec
Copy link

jpulec commented Jun 21, 2018

Because of https://github.com/jorisroovers/gitlint/blob/master/gitlint/hooks.py#L7 being hard-coded as .git/hooks, the install-hooks command doesn't seem to work when using git worktrees. Worktrees keep all of their hooks in the main repository folder.
@jpulec jpulec changed the title Can't use install-hooks in with workrtree Can't use install-hooks in with git worktree Jun 21, 2018
@rico-chet
Copy link

That variable should probably be result of git rev-parse --git-path hooks

@jorisroovers
Copy link
Owner

Sounds reasonable :) Will add this to the TODO list. No ETA on when I'll get to this (probably a few months, life get's busy...). Happy to accept PRs!

@jorisroovers jorisroovers added the enhancement User-facing feature enhancements label Oct 3, 2018
jorisroovers added a commit that referenced this issue Jun 19, 2019
@jorisroovers
Support for (un)installing hooks in git worktrees
1bb47e1 
correct path from git itself. This fixes issues with using git worktrees.

This fixes #68.
jorisroovers added a commit that referenced this issue Jun 19, 2019
@jorisroovers
Support for (un)installing hooks in git worktrees
af74eb2 
Gitlint no longer hardcodes the path of the commit-msg hook, but takes the
correct path from git itself. This fixes issues with using git worktrees.

This fixes #68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User-facing feature enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpulec @jorisroovers @rico-chet