Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--commits doesn't take commit specific config into account #24

Closed
jorisroovers opened this issue Mar 14, 2017 · 0 comments
Closed

--commits doesn't take commit specific config into account #24

jorisroovers opened this issue Mar 14, 2017 · 0 comments
Labels
bug User-facing bugs

Comments

@jorisroovers
Copy link
Owner

We currently only apply the commit-specific config of the last commit, not of every commit in the specified range. The following code block needs to be moved to the for-loop below it:
https://github.com/jorisroovers/gitlint/blob/master/gitlint/cli.py#L127-L131

CC: @tommyip
@jorisroovers jorisroovers changed the title When linting multiple commits using --commits, commit-specific config is taken into account correclty When using --commits, commit-specific config is not taken into account Mar 14, 2017
@jorisroovers jorisroovers changed the title When using --commits, commit-specific config is not taken into account --commits doesn commit-specific config is not taken into account Mar 14, 2017
@jorisroovers jorisroovers changed the title --commits doesn commit-specific config is not taken into account --commits doesn't take commit specific config into account Mar 14, 2017
@jorisroovers jorisroovers added the bug User-facing bugs label Mar 14, 2017
@jorisroovers jorisroovers mentioned this issue Mar 16, 2017
Merged
jorisroovers pushed a commit that referenced this issue Mar 16, 2017
@jroovers-cisco
0.8.1 release
4da2656 
The 0.8.1 release brings minor tweaks and some experimental features.
Special thanks to tommyip for his contributions.

- Experimental: Linting a range of commits. Known Caveats: #23, #24.
  Thanks to tommyip for implementing this!
- Experimental: Python 3.6 support
- Improved Windows error messaging: gitlint will now show a more
  descriptive error message when ran on windows.
  See #20 for details on the lack of Windows support.

Full Release details in CHANGELOG.md.
jorisroovers pushed a commit that referenced this issue Apr 25, 2017
@jroovers-cisco
0.8.2 release
2cb5353 
The 0.8.2 release brings minor improvements, bugfixes and some
under-the-hood changes. Special thanks to tommyip for his contributions.

- --extra-path now also accepts a file path (in the past only directory
paths where accepted). Thanks to tommyip for implementing this!
- gitlint will now show more information when using the --debug flag. This
is initial work and will continue to be improved upon in later releases.
- Bugfixes:
   - #24: --commits doesn't take commit specific config into account
   - #27: --commits returns the wrong exit code

- Development: better unit and integration test coverage for --commits

Full Release details in CHANGELOG.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug User-facing bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorisroovers