Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT1: contrib-title-conventional-commits only checks the start of the commit type #185

Closed
linjiX opened this issue Apr 3, 2021 · 1 comment
Closed

CT1: contrib-title-conventional-commits only checks the start of the commit type #185

linjiX opened this issue Apr 3, 2021 · 1 comment
Labels
bug User-facing bugs
Milestone
0.16.0

Comments

@linjiX
Copy link

linjiX commented Apr 3, 2021

Regular conventional commit message passes the gitlint check:

$ echo "test(scope): title" | gitlint --contrib=CT1 -c general.ignore=body-is-missing

But if adding a s after the commit type test, it also passes the check：

$ echo "tests(scope): title" | gitlint --contrib=CT1 -c general.ignore=body-is-missing

Even if adding some irrelevant letters after the type：

$ echo "testsaslkdjshdfk(scope): title" | gitlint --contrib=CT1 -c general.ignore=body-is-missing
@linjiX linjiX changed the title Contrib rule CT1: contrib-title-conventional-commits only checks the start of the commit type CT1: contrib-title-conventional-commits only checks the start of the commit type Apr 3, 2021
@rafaelbubach rafaelbubach mentioned this issue May 14, 2021
Merged
@jorisroovers jorisroovers added this to the 0.15.2 milestone Sep 19, 2021
@jorisroovers jorisroovers added the bug User-facing bugs label Sep 19, 2021
@jorisroovers
Copy link
Owner

This was fixed in #190, closing this.

@jorisroovers jorisroovers modified the milestones: 0.15.2, 0.16.0 Sep 27, 2021
jorisroovers added a commit that referenced this issue Oct 8, 2021
@jorisroovers
0.16.0 release
0be7cbe 
- Python 3.10 support
- New Rule: ignore-by-author-name allows users to skip linting commit messages
  made by specific authors
- --commit <SHA> flag to more easily lint a single commit message (#141)
- --fail-without-commits flag will force gitlint to fail (exit code 253) when
  the target commit range is empty (typically when using --commits) (#193)
- Bugfixes:
  - contrib-title-conventional-commits (CT1) now properly enforces the commit
    type (#185)
  - contrib-title-conventional-commits (CT1) now supports the BREAKING CHANGE
    symbol "!" (#186)
- Under-the-hood: dependencies updated, test and github action improvements.

Full Release details in CHANGELOG.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug User-facing bugs
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
2 participants
@jorisroovers @linjiX