refactor: little refactor to follow our code style and 100% coverage.…

… Support for file types
joolfe · Jul 24, 2021 · b569785 · b569785
1 parent 91ce1a9
commit b569785
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 17 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -171,15 +171,14 @@ function parseBody (body = {}, method) {
         'multipart/form-data': {
           schema: {
             type: 'object',
-            properties: body.formdata.reduce((acc, v) => {
-              acc[v.key] = { type: v.type === 'text' ? 'string' : v.type }
-              if (Object.prototype.hasOwnProperty.call(v, 'description')) {
-                acc[v.key].description = v.description === '' ? 'Description' : v.description
+            properties: body.formdata.reduce((obj, { key, type, description, value }) => {
+              obj[key] = {
+                type: 'string',
+                ...(description ? { description } : {}),
+                ...(value ? { example: value } : {}),
+                ...(type === 'file' ? { format: 'binary' } : {})
               }
-              if (Object.prototype.hasOwnProperty.call(v, 'value') && v.value !== '') {
-                acc[v.key].example = v.value
-              };
-              return acc
+              return obj
             }, {})
           }
         }

diff --git a/test/resources/input/v2/FormData.json b/test/resources/input/v2/FormData.json
@@ -1,8 +1,8 @@
 {
 	"info": {
-		"_postman_id": "1eaa74c4-2d76-45f0-bd34-bff5d96f0ba8",
+		"_postman_id": "66fd929e-c84f-4bc5-970a-60231fe16f5b",
 		"name": "Form Data",
-    "description": "Just a collection with a form data post for test",
+		"description": "Just a collection with a form data post for test",
 		"schema": "https://schema.getpostman.com/json/collection/v2.0.0/collection.json"
 	},
 	"item": [
@@ -29,8 +29,13 @@
 						{
 							"key": "password",
 							"value": "pasword123",
-							"description": "password (to be used for logging in)",
 							"type": "text"
+						},
+						{
+							"key": "profileImage",
+							"description": "User avatar",
+							"type": "file",
+							"src": []
 						}
 					]
 				},
@@ -39,4 +44,4 @@
 			"response": []
 		}
 	]
-}
+}
diff --git a/test/resources/input/v21/FormData.json b/test/resources/input/v21/FormData.json
@@ -1,8 +1,8 @@
 {
 	"info": {
-		"_postman_id": "1eaa74c4-2d76-45f0-bd34-bff5d96f0ba8",
+		"_postman_id": "66fd929e-c84f-4bc5-970a-60231fe16f5b",
 		"name": "Form Data",
-    "description": "Just a collection with a form data post for test",
+		"description": "Just a collection with a form data post for test",
 		"schema": "https://schema.getpostman.com/json/collection/v2.1.0/collection.json"
 	},
 	"item": [
@@ -29,8 +29,13 @@
 						{
 							"key": "password",
 							"value": "pasword123",
-							"description": "password (to be used for logging in)",
 							"type": "text"
+						},
+						{
+							"key": "profileImage",
+							"description": "User avatar",
+							"type": "file",
+							"src": []
 						}
 					]
 				},
@@ -49,4 +54,4 @@
 			"response": []
 		}
 	]
-}
+}
diff --git a/test/resources/output/FormData.yml b/test/resources/output/FormData.yml
@@ -27,8 +27,11 @@ paths:
                   example: newuser@example.com
                 password:
                   type: string
-                  description: password (to be used for logging in)
                   example: pasword123
+                profileImage:
+                  type: string
+                  description: User avatar
+                  format: binary
       responses:
         '200':
           description: Successful response