-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demangle option to collapsers #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
reviewed
Jul 2, 2019
jonhoo
reviewed
Jul 2, 2019
jonhoo
previously approved these changes
Jul 2, 2019
Looks like |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
- Coverage 90.12% 89.72% -0.4%
=========================================
Files 8 8
Lines 962 983 +21
=========================================
+ Hits 867 882 +15
- Misses 95 101 +6
Continue to review full report at Codecov.
|
jonhoo
reviewed
Jul 2, 2019
jonhoo
reviewed
Jul 2, 2019
jonhoo
reviewed
Jul 2, 2019
jonhoo
approved these changes
Jul 2, 2019
This was referenced Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
This is only useful if you pass
--no-demangle
toperf script
, or-xmangled
todtrace
.Since DTrace doesn't do a great job demangling Rust names, you can get better results by leaving names mangled in profiles, then passing
--demangle
toinferno-collapse-dtrace
. It would probably make sense for ferrous-systems/flamegraph to use DTrace this way.