-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use error type instead of using catch all failure::Error in Producer::con #8
Comments
For the various methods on |
@wezm still want to take a stab at this too? I'd be happy to review and merge! |
I've moved away from using Faktory for my project so don't have a huge personal need to implement this or #9 (comment). However I do need a couple more PRs for Hacktoberfest so might see if I can implement this one. |
Per the failure guidance the
failure::Error
type is typically only recommended when prototyping or for "applications" that won't handle the error. It would be better to define a custom error type and 'derive Fail' for it.I see there are some parts of the code using a custom error type but others are falling back on Error.
If this sounds reasonable I'm happy to make this change.
The text was updated successfully, but these errors were encountered: