Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.7.0, drop default features, and drop compatibility re-exports #8

Conversation

joshtriplett
Copy link
Contributor

@joshtriplett joshtriplett commented May 8, 2022

Dropping the default features makes it easy for library crates to depend on async-bincode without having to explicitly use default-features = false; libraries and applications that want to select an ecosystem can then enable the corresponding feature.

This depends on #5.

This uses macros to minimize code duplication. Both the `futures` and
`tokio` features can be enabled simultaneously.

Re-export the tokio versions for compatibility.
…re-exports

Dropping the default features makes it easy for library crates to depend
on async-bincode without having to explicitly use `default-features =
false`; libraries and applications that want to select an ecosystem can
then enable the corresponding feature.
@jonhoo
Copy link
Owner

jonhoo commented May 8, 2022

Dropped the top-level export in b1c9ead.

I'd like to keep the default feature though given the order-of-magnitude adoption difference between tokio and futures-io-based runtimes — it is just far more likely that a user will want to use tokio, so it'd seems like a reasonable and more ergonomic default for most users.

Will cut 0.7.0 shortly — thanks for the help!

@jonhoo jonhoo closed this May 8, 2022
@jonhoo
Copy link
Owner

jonhoo commented May 8, 2022

Published 0.7.0 🎉

@joshtriplett joshtriplett deleted the bump-version-modify-default-features branch May 8, 2022 20:28
jonhoo added a commit that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants