Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add markdown-template required methods #1

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

smoya
Copy link
Collaborator

@smoya smoya commented Apr 15, 2021

This PR adds all methods required by https://github.com/asyncapi/markdown-template to the new Parser API.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Owner

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had a few suggestions 👍

docs/API.md Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
@smoya smoya requested a review from jonaslagoni April 15, 2021 14:00
docs/API.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
@smoya smoya requested a review from jonaslagoni April 19, 2021 16:19
@smoya
Copy link
Collaborator Author

smoya commented Apr 19, 2021

I would still like to have a +1 here @derberg @jonaslagoni :)

@smoya smoya merged commit 47688c2 into feature/new_intent_api Apr 19, 2021
@smoya smoya deleted the markdown-template-methods branch April 19, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants