CI: Use --all-targets and --workspace where possible #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 36 36
Lines 2101 2101
=======================================
Hits 1620 1620
Misses 481 481 Continue to review full report at Codecov.
|
|
bors r+ |
|
Build succeeded: |
jonasbb
added a commit
that referenced
this pull request
Jan 30, 2021
The `--all-targets` flag for `cargo test` actually DISABLES doctests. Doctests should of course be run, so removing the flag from the CI scrips. There is a bug report for cargo about this behavior: rust-lang/cargo#6669 This fixes the changes done in #235 / 9a6c3bf.
bors bot
added a commit
that referenced
this pull request
Jan 30, 2021
253: Do not call `cargo test` with `--all-targets` r=jonasbb a=jonasbb The `--all-targets` flag for `cargo test` actually DISABLES doctests. Doctests should of course be run, so removing the flag from the CI scrips. There is a bug report for cargo about this behavior: rust-lang/cargo#6669 This fixes the changes done in #235 / 9a6c3bf. Co-authored-by: Jonas Bushart <jonas@bushart.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.