Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation and autocompletion for Trigger Types #1

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add validation and autocompletion for Trigger Types #1

merged 1 commit into from
Jul 12, 2023

Conversation

gugahoi
Copy link
Contributor

@gugahoi gugahoi commented Jul 12, 2023

This commit adds validation and autocompletes for trigger types when creating a webhook.

If the user types:

webflowctl webhooks create 112312321 [TAB]

It will suggest all available types. It will further filter the suggestions based on what is already typed.

@gugahoi gugahoi requested review from anonimitoraf and Nevvulo July 12, 2023 03:49
Nevvulo
Nevvulo approved these changes Jul 12, 2023
View reviewed changes
Copy link

@Nevvulo Nevvulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gugahoi gugahoi merged commit 697fc39 into master Jul 12, 2023
@gugahoi gugahoi deleted the feature/validate-webhook-types branch July 12, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevvulo Nevvulo Nevvulo approved these changes

@anonimitoraf anonimitoraf Awaiting requested review from anonimitoraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gugahoi @Nevvulo