Fixes date/location parsing from Papercall #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Awesome work in finding and fixing the issue. I need to fix the CI issue later so worst case scenario would be that the parser is fixed tomorrow. |
|
Thanks! The new CLI is being deployed currently and the next run (around 01:00 UTC IIRC) will use your changes. So tomorrow the results should be fixed for papercall.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @heiglandreas, thanks for the great work on this repo!
As mentioned here: joindin/callingallpapers-api#52
I noticed the event dates and locations were not being parsed properly. I'm guessing Papercall updated the DOM and broke this.
The fix was rather simple once I got the repo working locally. I added a couple notes to the Readme to help others who might work on on this project as well.
Please let me know if there's anything else I can do!