Add Sessionize-Data #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a parser that allows to read CfP-Infos from sessionize # Bitte geben Sie eine Commit-Beschreibung für Ihre Änderungen ein. Zeilen, # die mit '#' beginnen, werden ignoriert, und eine leere Beschreibung # bricht den Commit ab. # # Auf Branch addConfsTech # Ihr Branch ist auf demselben Stand wie 'origin/addConfsTech'. # # Zum Commit vorgemerkte Änderungen: # geändert: bin/callingallpapers # geändert: composer.json # geändert: phpunit.xml.dist # neue Datei: src/Command/AbstractParseEvents.php # neue Datei: src/Service/ServiceContainer.php # neue Datei: src/Subcommands/Sessionize/Command.php # neue Datei: src/Subcommands/Sessionize/Parser/ClosingDate.php # neue Datei: src/Subcommands/Sessionize/Parser/Description.php # neue Datei: src/Subcommands/Sessionize/Parser/EntryParser.php # neue Datei: src/Subcommands/Sessionize/Parser/EventEndDate.php # neue Datei: src/Subcommands/Sessionize/Parser/EventName.php # neue Datei: src/Subcommands/Sessionize/Parser/EventStartDate.php # neue Datei: src/Subcommands/Sessionize/Parser/EventUri.php # neue Datei: src/Subcommands/Sessionize/Parser/IconUri.php # neue Datei: src/Subcommands/Sessionize/Parser/Location.php # neue Datei: src/Subcommands/Sessionize/Parser/OpeningDate.php # neue Datei: src/Subcommands/Sessionize/Parser/Sessionize.php # neue Datei: tests/Subcommands/Sessionize/IntegrationTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/ClosingDateTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/EventDescriptionTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/EventEndDateTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/EventNameTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/EventStartDateTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/EventUriTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/IconUriTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/LocationTest.php # neue Datei: tests/Subcommands/Sessionize/Parser/OpeningDateTest.php # neue Datei: tests/Subcommands/Sessionize/__assets/Azure Day Rome 2019: Call for Speakers @ Sessionize.com.html # neue Datei: "tests/Subcommands/Sessionize/__assets/React Week Medell\303\255n 2019: Call for Speakers @ Sessionize.com.html" #
3708bf0 to
205ec72
Compare
205ec72 to
ad20f87
Compare
cookieguru
reviewed
Feb 3, 2020
| throw new \InvalidArgumentException('The CfP does not seem to have an EventUri'); | ||
| } | ||
|
|
||
| $uriPath = $xpath->query('//h2/a', $uriPath->item(0)->parentNode); |
There was a problem hiding this comment.
The // xpath will actually find this anywhere in the document, even though you passed in the $contextNode parameter. The xpath should be .//h2/a
There was a problem hiding this comment.
Thanks! Fixed that in the Location-class as well
There was a problem hiding this comment.
I would also like to thank GitHub's "start review" feature for leaving that comment hidden for 9 months until your most recent commit brought me to the diff to see its pending status 🤦♂️
This allows us to only use PHPUnit8. For that some tests needed to be adapted due to deprecated features that caused warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a parser that allows to read CfP-Infos from sessionize