Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field deprecation #50

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Fix field deprecation #50

merged 5 commits into from
Oct 7, 2021

Conversation

castarco
Copy link
Contributor

@castarco castarco commented Oct 7, 2021

The JSDoc annotation for deprecated fields was only added when the message itself was deprecated too.

  • This PR fixes that, allowing to deprecate individual fields without having to deprecate the whole message.
  • It also introduces a regression test that verifies the generated code by loading its AST.

@castarco castarco merged commit 6950541 into master Oct 7, 2021
@castarco castarco deleted the fix-field-deprecation branch October 7, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cann0neer cann0neer cann0neer approved these changes

@kirpichenko kirpichenko kirpichenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@castarco @kirpichenko @cann0neer