fix: make abstract service methods public

join-com · Apr 28, 2021 · cb96918 · cb96918
1 parent a701485
commit cb96918
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/internal/generator/runer_generate_service.go b/internal/generator/runer_generate_service.go
@@ -140,7 +140,7 @@ func (r *Runner) generateTypescriptServiceAbstractClass(generatedFileStream *pro
 			returnType = "Promise<void>"
 		}
 
-		r.P(generatedFileStream, "protected abstract "+methodName+"(call: "+callType+"): "+returnType)
+		r.P(generatedFileStream, "public abstract "+methodName+"(call: "+callType+"): "+returnType)
 	}
 
 	r.indentLevel -= 2

diff --git a/tests/__tests__/generated/Flavors.ts b/tests/__tests__/generated/Flavors.ts
@@ -140,7 +140,7 @@ export namespace Flavors {
       )
     }
 
-    protected abstract Find(
+    public abstract Find(
       call: grpc.ServerUnaryCall<IUserRequest, IUserProfile>
     ): Promise<IUserProfile>
   }

diff --git a/tests/__tests__/generated/Test.ts b/tests/__tests__/generated/Test.ts
@@ -541,16 +541,16 @@ export namespace Foo {
       )
     }
 
-    protected abstract Find(
+    public abstract Find(
       call: grpc.ServerUnaryCall<IRequest, Common_Common.IOtherPkgMessage>
     ): Promise<Common_Common.IOtherPkgMessage>
-    protected abstract FindClientStream(
+    public abstract FindClientStream(
       call: grpc.ServerReadableStream<IRequest, Common_Common.IOtherPkgMessage>
     ): Promise<Common_Common.IOtherPkgMessage>
-    protected abstract FindServerStream(
+    public abstract FindServerStream(
       call: grpc.ServerWritableStream<IRequest, Common_Common.IOtherPkgMessage>
     ): Promise<void>
-    protected abstract FindBidiStream(
+    public abstract FindBidiStream(
       call: grpc.ServerDuplexStream<IRequest, Common_Common.IOtherPkgMessage>
     ): Promise<void>
   }