Merge pull request #37 from join-com/join-11804

[JOIN-11804] fix: always unwrap message into plain object
join-com · May 6, 2021 · 8f28672 · 8f28672
2 parents 87bc02a + 10c996e
commit 8f28672
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 24 deletions.
diff --git a/tests/__tests__/generated/Flavors.ts b/tests/__tests__/generated/Flavors.ts
@@ -105,10 +105,7 @@ export namespace Flavors {
     public userId?: UserId
 
     public asInterface(): IUserRequest {
-      /* eslint-disable @typescript-eslint/no-this-alias */
-      // tslint:disable-next-line: no-this-assignment
-      const message = this
-      /* eslint-enable @typescript-eslint/no-this-alias */
+      const message = { ...this }
       for (const fieldName of Object.keys(message)) {
         if (message[fieldName as keyof IUserRequest] == null) {
           // We remove the key to avoid problems with code making too many assumptions

diff --git a/tests/__tests__/generated/Test.ts b/tests/__tests__/generated/Test.ts
@@ -181,10 +181,7 @@ export namespace Foo {
     public title?: string
 
     public asInterface(): INested {
-      /* eslint-disable @typescript-eslint/no-this-alias */
-      // tslint:disable-next-line: no-this-assignment
-      const message = this
-      /* eslint-enable @typescript-eslint/no-this-alias */
+      const message = { ...this }
       for (const fieldName of Object.keys(message)) {
         if (message[fieldName as keyof INested] == null) {
           // We remove the key to avoid problems with code making too many assumptions
@@ -222,10 +219,7 @@ export namespace Foo {
     public id?: number
 
     public asInterface(): IRequest {
-      /* eslint-disable @typescript-eslint/no-this-alias */
-      // tslint:disable-next-line: no-this-assignment
-      const message = this
-      /* eslint-enable @typescript-eslint/no-this-alias */
+      const message = { ...this }
       for (const fieldName of Object.keys(message)) {
         if (message[fieldName as keyof IRequest] == null) {
           // We remove the key to avoid problems with code making too many assumptions
@@ -269,10 +263,7 @@ export namespace Foo {
     public optionalField?: number
 
     public asInterface(): IRequiredPropertiesTest {
-      /* eslint-disable @typescript-eslint/no-this-alias */
-      // tslint:disable-next-line: no-this-assignment
-      const message = this
-      /* eslint-enable @typescript-eslint/no-this-alias */
+      const message = { ...this }
       for (const fieldName of Object.keys(message)) {
         if (message[fieldName as keyof IRequiredPropertiesTest] == null) {
           // We remove the key to avoid problems with code making too many assumptions

diff --git a/tests/__tests__/generated/common/Common.ts b/tests/__tests__/generated/common/Common.ts
@@ -25,10 +25,7 @@ export namespace Common {
     public latsName?: string
 
     public asInterface(): IOtherPkgMessage {
-      /* eslint-disable @typescript-eslint/no-this-alias */
-      // tslint:disable-next-line: no-this-assignment
-      const message = this
-      /* eslint-enable @typescript-eslint/no-this-alias */
+      const message = { ...this }
       for (const fieldName of Object.keys(message)) {
         if (message[fieldName as keyof IOtherPkgMessage] == null) {
           // We remove the key to avoid problems with code making too many assumptions

diff --git a/tests/__tests__/generated/google/protobuf/Timestamp.ts b/tests/__tests__/generated/google/protobuf/Timestamp.ts
@@ -25,10 +25,7 @@ export namespace GoogleProtobuf {
     public nanos?: number
 
     public asInterface(): ITimestamp {
-      /* eslint-disable @typescript-eslint/no-this-alias */
-      // tslint:disable-next-line: no-this-assignment
-      const message = this
-      /* eslint-enable @typescript-eslint/no-this-alias */
+      const message = { ...this }
       for (const fieldName of Object.keys(message)) {
         if (message[fieldName as keyof ITimestamp] == null) {
           // We remove the key to avoid problems with code making too many assumptions