Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update example app #58

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Fix/update example app #58

merged 2 commits into from
Oct 29, 2017

Conversation

iwasrobbed
Copy link
Collaborator

@iwasrobbed iwasrobbed commented Oct 29, 2017 •
edited
Loading

Fixes #57

Changes

  • Ensure the example app builds the Down.framework by linking to the Down.xcodeproj file instead of the actual framework on disk.
    • This is the standard way to manually embed libraries.
  • Update the example app w/ part of this repo's README.md

This was referenced Oct 29, 2017
Closed
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.756% when pulling 2af0b93 on fix/example into 642c564 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.756% when pulling 640f3e5 on fix/example into 642c564 on master.

@iwasrobbed iwasrobbed merged commit eb4e820 into master Oct 29, 2017
@iwasrobbed iwasrobbed deleted the fix/example branch October 29, 2017 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwasrobbed @coveralls