Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested project fixes/changes #28

Merged
merged 2 commits into from
May 8, 2017

Conversation

tonyarnold
Copy link
Collaborator

This PR is a recommendation for some changes you could make to simplify the maintenance of the project.

There are three main changes in this PR:

  • Removes the macOS framework dependency from the iOS test target
  • Removes and reorganises the orphaned Info.plist files in the project
  • Converts the targets and schemes to a single multi-platform variant that will build for the appropriate platform at build time

Completely up to you if you want to cherry pick ideas from this instead of accepting it as-is.

tonyarnold added 2 commits May 8, 2017 14:48
This is a multi-platform target, which will compile for the appropriate platform when needed.
@coveralls
Copy link

Coverage Status

Coverage increased (+4.8%) to 85.816% when pulling f2169a1 on tonyarnold:fix/project-issues into c53646a on iwasrobbed:master.

@128keaton
Copy link
Collaborator

Wow! Looks great! Thanks!

@128keaton 128keaton merged commit b944f1a into johnxnguyen:master May 8, 2017
@iwasrobbed
Copy link
Collaborator

Thanks @tonyarnold (and @128keaton for reviewing); also, I added you as a collaborator

@tonyarnold tonyarnold deleted the fix/project-issues branch May 8, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants