Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Use SPM to manage snapshot testing dependency #247

Merged
merged 5 commits into from
Feb 21, 2021

Conversation

johnxnguyen
Copy link
Owner

What's in this PR?

Changes

  • Use SPM to manage the snapshot testing framework
  • Remove Carthage files
  • Re-record snapshots with iPhone 12 simulator
  • Update travis config to use Xcode 12.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-io
Copy link

Codecov Report

Merging #247 (00e70f4) into master (21d522d) will decrease coverage by 35.56%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #247       +/-   ##
===========================================
- Coverage   68.73%   33.17%   -35.57%     
===========================================
  Files          75       75               
  Lines        2050     2062       +12     
===========================================
- Hits         1409      684      -725     
- Misses        641     1378      +737     
Impacted Files Coverage Δ
Tests/Styler/BlockQuoteStyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/CodeBlockStyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/DownDebugLayoutManagerTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/HeadingStyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/InlineStyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/LinkStyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/ListItemStyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Tests/Styler/StylerTestSuite.swift 0.00% <0.00%> (-98.87%) ⬇️
Tests/Styler/ThematicBreakSyleTests.swift 0.00% <ø> (-100.00%) ⬇️
Source/AST/Nodes/Code.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d522d...00e70f4. Read the comment docs.

@johnxnguyen
Copy link
Owner Author

Codecov appears to be borked, will need to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants