Resolves Swift Package Manager issue related to swift-snapshot-testing #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 32.59% 32.59%
=======================================
Files 74 74
Lines 2362 2362
=======================================
Hits 770 770
Misses 1592 1592Continue to review full report at Codecov.
|
iwasrobbed
approved these changes
Feb 28, 2020
Merged
regennz
pushed a commit
to regennz/Down
that referenced
this pull request
Apr 14, 2020
johnxnguyen#203) * Tidied up some formatting inconsistencies in Package.swift * Modified SwiftPM testTarget specification to exclude DownSnapshotTests * Applied some final clarifying changes to Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request proposes a solution for #202, which identified an issue where the framework would fail to build when the package was opened via
xed.Details
SnapshotTesting.SnapshotTestingas a dependency would require changes to the minimum deployment targets of the framework, and might also required updates to the reference snapshots.SnapshotTesting, allowing the existing minimum deployment targets to be preserved.Testing
The branch should build & tests should pass.