Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DownView] Add parameter so bundle is writable #200

Merged
merged 6 commits into from
Apr 25, 2020

Conversation

brunnobga
Copy link
Contributor

@brunnobga brunnobga commented Feb 14, 2020

Closes #198

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #200 into master will increase coverage by 37.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #200       +/-   ##
===========================================
+ Coverage   32.86%   70.07%   +37.21%     
===========================================
  Files          74       74               
  Lines        2048     2042        -6     
===========================================
+ Hits          673     1431      +758     
+ Misses       1375      611      -764     
Impacted Files Coverage Δ
Source/Views/DownView.swift 0.00% <0.00%> (-83.15%) ⬇️
Source/Extensions/String+ToHTML.swift 0.00% <0.00%> (-100.00%) ⬇️
Tests/AST/ListItemPrefixGeneratorTests.swift 0.00% <0.00%> (-100.00%) ⬇️
Tests/Styler/Helpers/CGRect_HelpersTests.swift 0.00% <0.00%> (-100.00%) ⬇️
Tests/Styler/Helpers/CGPoint_TranslateTests.swift 0.00% <0.00%> (-100.00%) ⬇️
...yler/Helpers/NSAttributedString+HelpersTests.swift 0.00% <0.00%> (-100.00%) ⬇️
...rs/NSMutableAttributedString+AttributesTests.swift 0.00% <0.00%> (-99.15%) ⬇️
Tests/AST/NodeTests.swift 0.00% <0.00%> (-96.16%) ⬇️
Source/Extensions/NSAttributedString+HTML.swift 0.00% <0.00%> (-87.50%) ⬇️
Source/Renderers/DownXMLRenderable.swift 0.00% <0.00%> (-83.34%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6c587...30502b7. Read the comment docs.

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brunnobga 👋 Thanks for the pull request! Please add a unit test (see examples in https://github.com/iwasrobbed/Down/blob/master/Tests/DownViewTests.swift) and then this can get merged 👍

@brunnobraga
Copy link
Contributor

Added a unit test to cover the boolean option I added. It would never actually fail on simulator since WKWebView doesn't apply the same permissions restrictions as on a real device. But it illustrates its purpose.

@iwasrobbed iwasrobbed changed the title adding parameter for bundle to be writable [DownView] Add parameter so bundle is writable Mar 19, 2020
Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brunnobga 👍

@iwasrobbed iwasrobbed merged commit dd2a448 into johnxnguyen:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Local images not accessible from WKWebView
4 participants