-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DownView] Add parameter so bundle is writable #200
[DownView] Add parameter so bundle is writable #200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
===========================================
+ Coverage 32.86% 70.07% +37.21%
===========================================
Files 74 74
Lines 2048 2042 -6
===========================================
+ Hits 673 1431 +758
+ Misses 1375 611 -764
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @brunnobga 👋 Thanks for the pull request! Please add a unit test (see examples in https://github.com/iwasrobbed/Down/blob/master/Tests/DownViewTests.swift) and then this can get merged 👍
Added a unit test to cover the boolean option I added. It would never actually fail on simulator since WKWebView doesn't apply the same permissions restrictions as on a real device. But it illustrates its purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brunnobga 👍
Closes #198