Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make color & font collection initializers public #184

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

johnxnguyen
Copy link
Owner

What's in this PR?

A small fix for #182

Issues

The initializers for StaticColorCollection and StaticFontCollection are not publicly accessible, thus their properties could not be set.

Causes

The generated memberwise struct initializer is internal by default, even if the struct has public access.

Solutions

Explicitly define public memberwise initializers with default values.

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0095468). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #184   +/-   ##
=========================================
  Coverage          ?   35.98%           
=========================================
  Files             ?       54           
  Lines             ?     1070           
  Branches          ?        0           
=========================================
  Hits              ?      385           
  Misses            ?      685           
  Partials          ?        0
Impacted Files Coverage Δ
...Styling/Attribute Collections/FontCollection.swift 0% <0%> (ø)
...tyling/Attribute Collections/ColorCollection.swift 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0095468...944dc03. Read the comment docs.

@iwasrobbed
Copy link
Collaborator

Thanks @johnxnguyen !

@iwasrobbed iwasrobbed merged commit b99cbca into master Oct 22, 2019
@iwasrobbed iwasrobbed deleted the fix/public-initializers branch October 22, 2019 14:17
@iwasrobbed iwasrobbed mentioned this pull request Oct 22, 2019
1 task
@vzsg vzsg mentioned this pull request Feb 24, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants