Wrap openURL so that Down compiles in app extensions #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DownView couldn’t compile in app extensions because of the use of UIApplication.shared.openURL - With this change, an empty wrapper is used to allow DownView to compile and be usable in app extensions, with the downside that links cannot be opened
iwasrobbed
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use Down within the WordPress app, but the primary use would be in our share extension, when Markdown is imported from other apps.
Currently Down can't be used in app extensions because
DownViewusesUIApplication.shared.openURL, which isn't available in AppExtensions. With this change a wrapper method is used to allowDownViewto compile and be usable in app extensions, with the concession that links cannot be opened in app extensions.I'm open to suggestions on better ways to allow Down to be used in app extensions.