-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dry-run flag behaviour #5
Conversation
action.yml
Outdated
@@ -80,14 +80,14 @@ runs: | |||
shell: bash | |||
|
|||
- name: Generate attestation for the plugin | |||
if: ${{ ! inputs.dry-run }} | |||
if: ${{ inputs.dry-run == false }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write != true
You can always add a temporary debug step run: echo dry-run=${{ toJSON(inputs.dry-run) }}
# or
run: echo inputs=${{ toJSON(inputs) }} |
@szepeviktor What am I doing wrong? This run has the The input values can be seen at the top by expanding the arrow next to
|
Try that debug step! |
Oh the value is being set to string
|
Yep that looks correct. Inputs for actions are strings only: https://stackoverflow.com/a/76294014 |
Okay we're looking good now. What a pickle. |
Actually
|
Thanks for the assistance @szepeviktor 💪 |
See #4.
Still needs more work.