Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Poise error #4

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Fix Poise error #4

merged 1 commit into from
Mar 23, 2016

Conversation

Ginja
Copy link
Contributor

@Ginja Ginja commented Mar 23, 2016

name_property should be name_attribute. Also re-introduced prepending run_context for the include_recipe call to support older Chef clients.

@Ginja
Fix Poise error
1c5f8f0 
name_property should be name_attribute. Also re-introduced
prepending run_context for the include_recipe call for older
Chef clients.
@Ginja Ginja mentioned this pull request Mar 23, 2016
Merged
@johnbellone
Copy link
Owner

Does the include_recipe syntax not even work with Poise? What versions of Chef?

Sent from my iPhone
JB

On Mar 23, 2016, at 15:06, Riley Shott notifications@github.com wrote:

name_property should be name_attribute. Also re-introduced prepending run_context for the include_recipe call to support older Chef clients.

You can view, comment on, or merge this pull request online at:

#4

Commit Summary

Fix Poise error
File Changes

M libraries/zipfile.rb (6)
Patch Links:

https://github.com/johnbellone/rubyzip-cookbook/pull/4.patch
https://github.com/johnbellone/rubyzip-cookbook/pull/4.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@Ginja
Copy link
Contributor Author

Ginja commented Mar 23, 2016

No, unfortunately. I was seeing the same error. We're using 12.4.1.

@johnbellone johnbellone merged commit a3ebedf into johnbellone:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ginja @johnbellone