forked from Azure/autorest.typescript
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re generate cadl ranch tests #8
Open
joheredi
wants to merge
1
commit into
improve-static-file-handling
Choose a base branch
from
improve-static-file-handling-integration-update
base: improve-static-file-handling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 0 additions & 89 deletions
89
.../typespec-ts/test/modularIntegration/generated/azure/core/basic/src/models/pagingTypes.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,105 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
import { | ||
Client, | ||
createRestError, | ||
PathUncheckedResponse, | ||
} from "@azure-rest/core-client"; | ||
import { RestError } from "@azure/core-rest-pipeline"; | ||
import { | ||
BuildPagedAsyncIteratorOptions, | ||
ContinuablePage, | ||
PageSettings, | ||
PagedAsyncIterableIterator, | ||
PagedResult, | ||
} from "../models/pagingTypes.js"; | ||
import { isUnexpected } from "../rest/index.js"; | ||
|
||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
/** | ||
* Options for the byPage method | ||
*/ | ||
export interface PageSettings { | ||
/** | ||
* A reference to a specific page to start iterating from. | ||
*/ | ||
continuationToken?: string; | ||
} | ||
|
||
/** | ||
* An interface that describes a page of results. | ||
*/ | ||
export type ContinuablePage<TElement, TPage = TElement[]> = TPage & { | ||
/** | ||
* The token that keeps track of where to continue the iterator | ||
*/ | ||
continuationToken?: string; | ||
}; | ||
|
||
/** | ||
* An interface that allows async iterable iteration both to completion and by page. | ||
*/ | ||
export interface PagedAsyncIterableIterator< | ||
TElement, | ||
TPage = TElement[], | ||
TPageSettings extends PageSettings = PageSettings, | ||
> { | ||
/** | ||
* The next method, part of the iteration protocol | ||
*/ | ||
next(): Promise<IteratorResult<TElement>>; | ||
/** | ||
* The connection to the async iterator, part of the iteration protocol | ||
*/ | ||
[Symbol.asyncIterator](): PagedAsyncIterableIterator< | ||
TElement, | ||
TPage, | ||
TPageSettings | ||
>; | ||
/** | ||
* Return an AsyncIterableIterator that works a page at a time | ||
*/ | ||
byPage: ( | ||
settings?: TPageSettings, | ||
) => AsyncIterableIterator<ContinuablePage<TElement, TPage>>; | ||
} | ||
|
||
/** | ||
* An interface that describes how to communicate with the service. | ||
*/ | ||
export interface PagedResult< | ||
TElement, | ||
TPage = TElement[], | ||
TPageSettings extends PageSettings = PageSettings, | ||
> { | ||
/** | ||
* Link to the first page of results. | ||
*/ | ||
firstPageLink?: string; | ||
/** | ||
* A method that returns a page of results. | ||
*/ | ||
getPage: ( | ||
pageLink?: string, | ||
) => Promise<{ page: TPage; nextPageLink?: string } | undefined>; | ||
/** | ||
* a function to implement the `byPage` method on the paged async iterator. | ||
*/ | ||
byPage?: ( | ||
settings?: TPageSettings, | ||
) => AsyncIterableIterator<ContinuablePage<TElement, TPage>>; | ||
|
||
/** | ||
* A function to extract elements from a page. | ||
*/ | ||
toElements?: (page: TPage) => TElement[]; | ||
} | ||
|
||
/** | ||
* Options for the paging helper | ||
*/ | ||
export interface BuildPagedAsyncIteratorOptions { | ||
itemName?: string; | ||
nextLinkName?: string; | ||
} | ||
|
||
/** | ||
* Helper to paginate results in a generic way and return a PagedAsyncIterableIterator | ||
|
@@ -182,10 +267,23 @@ function getElements<T = unknown>(body: unknown, itemName: string): T[] { | |
* Checks if a request failed | ||
*/ | ||
function checkPagingRequest(response: PathUncheckedResponse): void { | ||
if (isUnexpected(response)) { | ||
throw createRestError( | ||
`Pagination failed with unexpected statusCode ${response.status}`, | ||
response, | ||
); | ||
const statusCode = Number(response.status); | ||
if (statusCode < 200 || statusCode >= 300) { | ||
if (statusCode >= 400 && statusCode < 500) { | ||
throw createRestError( | ||
`Pagination failed with client error statusCode ${response.status}`, | ||
response, | ||
); | ||
} else if (statusCode >= 500) { | ||
throw createRestError( | ||
`Pagination failed with server error statusCode ${response.status}`, | ||
response, | ||
); | ||
} else { | ||
throw createRestError( | ||
`Pagination failed with unexpected statusCode ${response.status}`, | ||
response, | ||
); | ||
} | ||
Comment on lines
-185
to
+287
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not quite sure why we remove isUnexpected helper ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it part of the removing rlc types change? |
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 8 additions & 8 deletions
16
...est/modularIntegration/generated/azure/core/lro/rpc/generated/src/restorePollerHelpers.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this duplicated?