Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace specific MRAcquisitionData children with base class reference #3

Open
johannesmayer opened this issue Aug 16, 2018 · 0 comments
Open

Replace specific MRAcquisitionData children with base class reference #3

johannesmayer opened this issue Aug 16, 2018 · 0 comments

Comments

@johannesmayer
Copy link
Owner

Various functions, for example

void aDynamic::bin_mr_acquisitions( sirf::AcquisitionsVector all_acquisitions );
typedef sirf::AcquisitionsVector MRDataType;
MRDataType intersect_mr_acquisition_data(MRDataType one_dat, MRDataType other_dat);

make use of an implementation of MRAcquisitionData but don't really need the specificity.
Replace them by reference to base class.
johannesmayer pushed a commit that referenced this issue Feb 21, 2022
@KrisThielemans
update documentation
2140fb3 
use jupyter notebooks as opposed to spyder

fixes #3
fixes #2
johannesmayer pushed a commit that referenced this issue Jul 29, 2022
@samdporter
Merge pull request #3 from SyneRBI/master
bd04b5e 
Update CONTRIBUTING.md (SyneRBI#1114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannesmayer