Remove deprecated ChromeDPTarget.attach() method

Resolves: #192
joffrey-bion · Aug 20, 2022 · 32825d9 · 32825d9
1 parent dd7af0c
commit 32825d9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/api/chrome-devtools-kotlin.api b/api/chrome-devtools-kotlin.api
@@ -41529,8 +41529,6 @@ public final class org/hildan/chrome/devtools/protocol/ChromeDPTarget {
 	public static final field Companion Lorg/hildan/chrome/devtools/protocol/ChromeDPTarget$Companion;
 	public synthetic fun <init> (ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
 	public fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V
-	public final fun attach (Lorg/hildan/krossbow/websocket/WebSocketClient;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
-	public static synthetic fun attach$default (Lorg/hildan/chrome/devtools/protocol/ChromeDPTarget;Lorg/hildan/krossbow/websocket/WebSocketClient;Lkotlin/coroutines/Continuation;ILjava/lang/Object;)Ljava/lang/Object;
 	public final fun component1 ()Ljava/lang/String;
 	public final fun component2 ()Ljava/lang/String;
 	public final fun component3 ()Ljava/lang/String;

diff --git a/src/main/kotlin/org/hildan/chrome/devtools/protocol/ChromeDPClient.kt b/src/main/kotlin/org/hildan/chrome/devtools/protocol/ChromeDPClient.kt
@@ -177,16 +177,7 @@ data class ChromeDPTarget(
     val description: String,
     val devtoolsFrontendUrl: String,
     val webSocketDebuggerUrl: String,
-) {
-    /**
-     * Attaches to this target via a new web socket connection to this target's debugger URL.
-     * This establishes a new protocol session to this target.
-     */
-    @Deprecated("this method provides no way of closing the created websocket connection, prefer using " +
-        "ChromeDPClient.webSocket and using the richer websocket API to interact with targets (ChromeBrowserSession.target)")
-    suspend fun attach(webSocketClient: WebSocketClient = DEFAULT_WEBSOCKET_CLIENT): ChromePageSession =
-        webSocketClient.connectToChrome(webSocketDebuggerUrl).attachToPage(id)
-}
+)
 
 /**
  * Connects to the Chrome debugger at the given [webSocketDebuggerUrl].