Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Phlex 2 support #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

triskweline
Copy link

This is a draft PR that adds support for Phlex 2.1 (and drops support for Phlex 1).

So far I fixed the tests and all deprecation warnings. I didn't do any testing beyond that.

@joelmoss
Copy link
Owner

joelmoss commented Mar 5, 2025

Amazing! Thanks for this, but I don't want to drop support for Phlex 1 just yet. I still use it heavily, and rely a lot on some of the things changed or removed in Phlex 2.

Version detection of Phlex would be best here. Any chance you could add that, so that these changes are only applied when Phlex 2+ is used?

@triskweline
Copy link
Author

I added version switches for Phlex 1/2.

I also added the appraisals gem to run tests for various Phlex versions. Tested gem sets are defined in the Appraisal file.

To run tests for all supported Phlex versions:

bundle exec appraisal sus

To run tests for a specific Phlex versions, call:

bundle exec appraisal phlex-1 sus
bundle exec appraisal phlex-2 sus

Again, I only made sure the tests pass, but did no manual testing beyond that.

@joelmoss
Copy link
Owner

joelmoss commented Mar 5, 2025

Thanks loads. Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants