Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move article status filter to bottom of feed list #763

Merged
merged 2 commits into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions app/src/main/java/com/capyreader/app/ui/articles/AddFeedButton.kt
Original file line number Diff line number Diff line change
Expand Up @@ -4,39 +4,54 @@ import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Add
import androidx.compose.material.icons.rounded.Add
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
import androidx.compose.material3.OutlinedButton
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.capyreader.app.R

@Composable
fun AddFeedButton(
onComplete: (feedID: String) -> Unit,
iconOnly: Boolean = false,
) {
val (isDialogOpen, setDialogOpen) = rememberSaveable { mutableStateOf(false) }

val closeDialog = {
setDialogOpen(false)
}

OutlinedButton(
onClick = { setDialogOpen(true) },
) {
Box(Modifier.padding(end = 8.dp)) {
val onClick = { setDialogOpen(true) }

if (iconOnly) {
IconButton(
onClick = onClick,
) {
Icon(
imageVector = Icons.Filled.Add,
contentDescription = null,
modifier = Modifier.size(18.dp)
painterResource(R.drawable.icon_add),
contentDescription = stringResource(R.string.nav_add_feed)
)
}
Text(stringResource(R.string.nav_add_feed))
} else {
OutlinedButton(onClick = onClick) {
Box(Modifier.padding(end = 8.dp)) {
Icon(
imageVector = Icons.Rounded.Add,
contentDescription = null,
modifier = Modifier.size(18.dp)
)
}
Text(stringResource(R.string.nav_add_feed))
}
}

if (isDialogOpen) {
Expand All @@ -49,3 +64,12 @@ fun AddFeedButton(
)
}
}

@Composable
@Preview
fun AddFeedButtonPreview() {
AddFeedButton(
onComplete = {},
iconOnly = true
)
}
64 changes: 36 additions & 28 deletions app/src/main/java/com/capyreader/app/ui/articles/ArticleLayout.kt
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,38 @@ fun ArticleLayout(
}
}

fun selectFilter() {
if (!filter.hasArticlesSelected()) {
openNextList { onSelectArticleFilter() }
} else {
closeDrawer()
}
}

fun selectStatus(status: ArticleStatus) {
coroutineScope.launchUI {
openNextStatus { onSelectStatus(status) }
}
}

fun selectFeed(feed: Feed, folderTitle: String?) {
coroutineScope.launch {
if (!filter.isFeedSelected(feed)) {
openNextList { onSelectFeed(feed.id, folderTitle) }
} else {
closeDrawer()
}
}
}

fun selectFolder(folder: Folder) {
if (!filter.isFolderSelect(folder)) {
openNextList { onSelectFolder(folder.title) }
} else {
closeDrawer()
}
}

ArticleHandler {
selectArticle(it)
}
Expand All @@ -280,38 +312,14 @@ fun ArticleLayout(
FeedList(
folders = folders,
feeds = feeds,
onSelectFolder = {
if (!filter.isFolderSelect(it)) {
openNextList { onSelectFolder(it.title) }
} else {
closeDrawer()
}
},
onSelectFeed = { feed, folderTitle ->
coroutineScope.launch {
if (!filter.isFeedSelected(feed)) {
openNextList { onSelectFeed(feed.id, folderTitle) }
} else {
closeDrawer()
}
}
},
onSelectFolder = ::selectFolder,
onSelectFeed = ::selectFeed,
onFeedAdded = { onFeedAdded(it) },
onNavigateToSettings = onNavigateToSettings,
onFilterSelect = {
if (!filter.hasArticlesSelected()) {
openNextList { onSelectArticleFilter() }
} else {
closeDrawer()
}
},
onFilterSelect = ::selectFilter,
filter = filter,
statusCount = statusCount,
onSelectStatus = {
coroutineScope.launchUI {
openNextStatus { onSelectStatus(it) }
}
}
onSelectStatus = ::selectStatus
)
},
listPane = {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package com.capyreader.app.ui.articles

import androidx.compose.material3.SegmentedButton
import androidx.compose.material3.SegmentedButtonDefaults
import androidx.compose.material3.SingleChoiceSegmentedButtonRow
import androidx.compose.runtime.Composable
import androidx.compose.ui.tooling.preview.Preview
import com.jocmp.capy.ArticleStatus

@Composable
fun ArticleStatusBar(
onSelectStatus: (status: ArticleStatus) -> Unit,
status: ArticleStatus,
) {
SingleChoiceSegmentedButtonRow {
options.forEachIndexed { index, buttonStatus ->
SegmentedButton(
shape = SegmentedButtonDefaults.itemShape(index = index, count = options.size),
onClick = {
if (buttonStatus != status) {
onSelectStatus(buttonStatus)
}
},
icon = {},
selected = buttonStatus == status
) {
ArticleStatusIcon(status = buttonStatus)
}
}
}
}

val options = listOf(
ArticleStatus.ALL,
ArticleStatus.UNREAD,
ArticleStatus.STARRED,
)

@Composable
@Preview
fun ArticleStatusBarPreview() {
ArticleStatusBar(
onSelectStatus = {},
status = ArticleStatus.UNREAD
)
}
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
package com.capyreader.app.ui.articles

import androidx.compose.foundation.layout.padding
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.rounded.Notes
import androidx.compose.material.icons.rounded.Star
import androidx.compose.material3.Icon
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.unit.dp
import com.capyreader.app.R
import com.jocmp.capy.ArticleStatus

Expand All @@ -23,7 +20,6 @@ fun ArticleStatusIcon(status: ArticleStatus) {
ArticleStatus.UNREAD -> Icon(
painterResource(R.drawable.icon_circle_filled),
contentDescription = null,
modifier = Modifier.padding(1.dp)
)

ArticleStatus.STARRED -> Icon(
Expand Down

This file was deleted.

Loading
Loading