Add 'Copy Link' option to article list menu (#729)

jocmp · Jan 16, 2025 · 2aae854 · 2aae854
1 parent 28469b5
commit 2aae854
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 10 deletions.
diff --git a/app/src/main/java/com/capyreader/app/ui/articles/EditFeedURLDisplay.kt b/app/src/main/java/com/capyreader/app/ui/articles/EditFeedURLDisplay.kt
@@ -15,23 +15,18 @@ import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
-import androidx.compose.ui.platform.LocalClipboardManager
 import androidx.compose.ui.res.stringResource
-import androidx.compose.ui.text.AnnotatedString
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.tooling.preview.Preview
 import com.capyreader.app.R
+import com.capyreader.app.ui.components.buildCopyToClipboard
 import com.capyreader.app.ui.theme.CapyTheme
 
 @Composable
 fun EditFeedURLDisplay(
     url: String
 ) {
-    val clipboardManager = LocalClipboardManager.current
-
-    val copyToClipboard = {
-        clipboardManager.setText(AnnotatedString(url))
-    }
+    val copyToClipboard = buildCopyToClipboard(url)
 
     Box(
         modifier = Modifier

diff --git a/app/src/main/java/com/capyreader/app/ui/articles/list/ArticleActionMenu.kt b/app/src/main/java/com/capyreader/app/ui/articles/list/ArticleActionMenu.kt
@@ -1,5 +1,7 @@
 package com.capyreader.app.ui.articles.list
 
+import androidx.compose.material.icons.Icons
+import androidx.compose.material.icons.rounded.ContentCopy
 import androidx.compose.material3.DropdownMenu
 import androidx.compose.material3.DropdownMenuItem
 import androidx.compose.material3.Icon
@@ -11,16 +13,17 @@ import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.tooling.preview.PreviewParameter
 import androidx.compose.ui.unit.DpOffset
 import androidx.compose.ui.unit.dp
-import com.jocmp.capy.MarkRead
-import com.jocmp.capy.MarkRead.After
-import com.jocmp.capy.MarkRead.Before
 import com.capyreader.app.R
 import com.capyreader.app.ui.articles.LocalArticleActions
 import com.capyreader.app.ui.components.ArticleAction
+import com.capyreader.app.ui.components.buildCopyToClipboard
 import com.capyreader.app.ui.components.readAction
 import com.capyreader.app.ui.components.starAction
 import com.capyreader.app.ui.fixtures.ArticleSample
 import com.jocmp.capy.Article
+import com.jocmp.capy.MarkRead
+import com.jocmp.capy.MarkRead.After
+import com.jocmp.capy.MarkRead.Before
 
 @Composable
 fun ArticleActionMenu(
@@ -56,9 +59,31 @@ fun ArticleActionMenu(
             text = { Text(stringResource(R.string.article_actions_mark_below_as_read)) },
             onClick = { onMarkAllRead(Before(article.id)) },
         )
+        CopyLinkMenuItem(onDismissRequest, article)
     }
 }
 
+@Composable
+private fun CopyLinkMenuItem(onDismissRequest: () -> Unit, article: Article) {
+    val url = article.url?.toString() ?: return
+
+    val copyToClipboard = buildCopyToClipboard(url)
+
+    DropdownMenuItem(
+        leadingIcon = {
+            Icon(
+                Icons.Rounded.ContentCopy,
+                contentDescription = null
+            )
+        },
+        text = { Text(stringResource(R.string.article_actions_copy_link)) },
+        onClick = {
+            copyToClipboard()
+            onDismissRequest()
+        },
+    )
+}
+
 @Composable
 private fun ToggleReadMenuItem(onDismissRequest: () -> Unit, article: Article) {
     val action = readAction(article, LocalArticleActions.current)

diff --git a/app/src/main/java/com/capyreader/app/ui/components/CopyToClipboard.kt b/app/src/main/java/com/capyreader/app/ui/components/CopyToClipboard.kt
@@ -0,0 +1,16 @@
+package com.capyreader.app.ui.components
+
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.platform.LocalClipboardManager
+import androidx.compose.ui.text.AnnotatedString
+
+@Composable
+fun buildCopyToClipboard(text: String): () -> Unit {
+    val clipboardManager = LocalClipboardManager.current
+
+    fun copy() {
+        clipboardManager.setText(AnnotatedString(text))
+    }
+
+    return ::copy
+}
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -64,6 +64,7 @@
     <string name="article_actions_open_menu">Open article actions</string>
     <string name="article_actions_mark_below_as_read">Mark below as read</string>
     <string name="article_actions_mark_after_as_read">Mark above as read</string>
+    <string name="article_actions_copy_link">Copy link</string>
     <string name="unauthorized_dialog_title">You\'re logged out</string>
     <string name="unauthorized_dialog_description">There was an issue connecting to your account. Please log in again.</string>
     <string name="unauthorized_dialog_dismiss_text">Later</string>