-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flymake fringe indicator and warning underline #632
Comments
Well? :-) |
please find the below.
|
Your solargraph server is not sending any diagnostics, as far as i can tell. I don't have enough information to explain to you why that is so, you must provide me with a small Emacs configuration, an example file, or something that gives me a hint. For all I know, maybe your file does not contain any syntax errors. |
Hi Joao, Please find the emacs config as attach. When i put in the require statement. Typing eg it expanded to egyptian-shape-grouping and not displaying eglot |
@badlirashid , I'm sorry for taking so long to look at this, but it's quite difficult to discern what you are dealing with here. If you want, please make a new issue and follow the instructions there closely. To be able to help you, I need a "minimal configuration" or "minimal complete recipe": You can also open a discussion [here|https://github.com/joaotavora/eglot/discussions] Here's what I'm looking for in a reproduction recipe, both in text form and video form, so it's as clear as possible. It's for Go and Emacs 26.3, so you could adapt it for your specific case. You don't have to follow this exact format, this is just to illustrate how the recipe rules out many intrusions from external factors. It tries to be a scientific reproducible experiment and rule-out interference from non-Eglot parts of your configuration. Minimal example configuration (in text form)
The same example minimal configuration (in video form) |
hi, Thank you for the reply,i will try with the elpa packages first as i am using the git source. |
It's fine to use the Git source. Even better. In that case the recipe becomes
|
hi, Thank you. |
OK, more or less I think this is something already. Now, running that same very simple recipe, please switch to the Eglot events buffer using My suspicion is that the |
Hi Joao, Please find the attach. The solargraph is at 0.40.4, i hope it helps. Regards, |
This event log is much much shorter than the one you posted before. What happened? (also, you can post text content directly in the GitHub chat dialog like this 👇 ):
|
You mean for the event on the Feb 28 ? It could be i am using the src version of libjasson (https://digip.org/jansson/), with the commit 2de2c3d5fc702396a2a5ae8f70ab98a0011d486e other than that i am not sure. Now i am just using the normal ubuntu distribution. |
@joaotavora please find the below, it is using the compile version (longer version)
|
I've reproduced your problem, but I don't think Eglot is at fault here. The ssolargraph erver transmits some signature help, but refuses to send any diagnotics for some reason. I've even tried running |
its okey joao, thank you. eglot is great by the way. |
hi @joaotavora , it is working with commit b06589b and 1ac06d0. Thank you. |
Fantastic!
…On Sun, May 16, 2021, 13:53 Badli Rashid ***@***.***> wrote:
Closed #632 <#632>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#632 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC6PQ6OL63Z5QZTY7PNP7DTN655TANCNFSM4YKSBVWQ>
.
|
I suspect I may be running into this same problem. I swore it was working at first, but I am now thinking that Trying it the past few days with eglot i feel like the server isn't responding with diagnostics. I'm not familiar at all with LSP itself, but it looks to me like this response doesn't include anything about diagnostics.
And I definitely don't see any messages later on as I'm mucking about in a project. I ask here just to try and confirm the findings, it looks like solargraph is primarily VS Code focused, i'm not sure why this issue wouldn't pop up there as well, but from what I recall, the LSP implementations don't always follow the spec? If you have any clues or suggestions on how to debug I'm all ears. Thanks! |
I think I may have tracked down the issue. Solargraph has diagnostics disabled by default. In VSCode, you have to go in and change the config to enable it (watched a coworker do it). I found an issue on the repo that sheds some more concrete light on it: castwide/solargraph#238 (comment) It looks like just sending the proper initialization options would do it. I can see that there is a way to specialize an eglot server to have different options, but I haven't yet tried doing it. Does this sound reasonable? Or would there be a way to send a request once the server is started? I'm in a weird situation where i'm manually starting the solargraph server in a container, and then manually connecting with eglot, so i might end up just needing a custom function to get it all working. |
Both are possible, but you probably want the latter. Eglot is mostly designed to use To set this, use something like this (caveat emptor, I did not test this): (setq eglot-workspace-configuration
'((solargraph (diagnostics . t)))) Or look at the per-project configuration if you don't care for enabling diagnostics everywhere. |
Yes, but mostly incidentally rather than intentionally. |
Yes, it sounds reasonable, but the I've already understood the problem, but if someone would make an issue out of that would speed up its fix, which isn't terribly hard. |
🤦🏽 yup. exactly what i was looking for. this should handle both of my issues. i'll check out the other thread with the bug. thanks for the replies! |
After eglot was connected and flymake was loaded.
The fringe indicator and warning underline was not shown. I have restarted flymake but the indicator and underline was not enable.
flymake have no issues if eglot was not loaded
i have tested with emacs 27.1.91 and 28.0.50. with git 2d44207.
Before submitting an issue, please, read our guidelines
on reporting bugs here:
https://github.com/joaotavora/eglot#reporting-bugs
The text was updated successfully, but these errors were encountered: