Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved workspace join process #522

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jo-gross
Copy link
Owner

Closing issues:

Before you mark this PR as ready, please check the following points

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I´e created all necessary migrations?
  • The format is correct (pnpm format:check, if invalid pnpm format:fix)
  • No build errors (pnpm build)
  • I´ve tested the implemented function by my own
  • Ensure the pr title fits the conventional commit standard

Describe your work, what changed

Until now you entered/invited members by sharing the workspace id. Obviously this is not the best way, you had no control about who is joining, ...

With this PR i improved the whole process by adding a JoinRequest list, showing the users who wants to join. Additionally i added random join codes with time and usage limitation options.

Affected sites (please check during review):

  • Settings got new list with users who wants to join
  • Workspace select page also shows the request list

Further comments

As mentioned in #521 some kind of notification would be awesome, but thats something for the future...

Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross self-assigned this Jan 21, 2025
@jo-gross jo-gross linked an issue Jan 21, 2025 that may be closed by this pull request
3 tasks
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross enabled auto-merge (squash) January 21, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Workspace join improvements
1 participant