-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved workspace join process #522
Open
jo-gross
wants to merge
12
commits into
main
Choose a base branch
from
104-feat-workspace-join-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
3 tasks
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issues:
Before you mark this PR as ready, please check the following points
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
pnpm format:check
, if invalidpnpm format:fix
)pnpm build
)Describe your work, what changed
Until now you entered/invited members by sharing the workspace id. Obviously this is not the best way, you had no control about who is joining, ...
With this PR i improved the whole process by adding a JoinRequest list, showing the users who wants to join. Additionally i added random join codes with time and usage limitation options.
Affected sites (please check during review):
Further comments
As mentioned in #521 some kind of notification would be awesome, but thats something for the future...