fix: Glass form was not accessable if the glass had no image #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
1 task
jhns-de
approved these changes
Mar 4, 2024
jg-semantic-release-bot bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
## [1.4.1](v1.4.0...v1.4.1) (2024-03-04) ### Bug Fixes * Cocktail forms calculation was not shown properly, changed volume validation at ingredients form ([#188](#188)) ([f3ef485](f3ef485)) * Fixed chrome ui bug (icon was not correctly displayed) ([#191](#191)) ([1a669bd](1a669bd)) * Glass form was not accessable if the glass had no image ([#189](#189)) ([96cc360](96cc360))
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issues:
Before you mark this PR as ready, please check the following points
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
yarn format:check, if invalidyarn format:fix)yarn build)Describe your work, what changed
If an glass had no image, the field "GlassImages" is undefined. So the access on that undefined throwes an exception.
Affected sites (please check during review):