Improve pretty-printing to support invalid bitflags #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may occur when values are reinterpreted from raw integers. Rather than printing a chain of ORs which do not sum to the explicit value (or worse yet, print nothing for a disjoint bitset), just tack on to the end of the chain the explicit numerical value of all unhandled bits. We can even represent this in the non-compact case as a reinterpret expression which is copy-pastable to re-form the given value.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 95.61% 97.05% +1.44%
==========================================
Files 1 1
Lines 114 136 +22
==========================================
+ Hits 109 132 +23
+ Misses 5 4 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may occur when values are reinterpreted from raw integers.
Rather than printing a chain of ORs which do not sum to the explicit
value (or worse yet, print nothing for a disjoint bitset), just tack
on to the end of the chain the explicit numerical value of all
unhandled bits.
We can even represent this in the non-compact case as a reinterpret
expression which is copy-pastable to re-form the given value.