Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to gather feedback, I really think an auto expire is missing from throttler: other rate limits like fastify-rate-limit automatically calculate the blockDuration by looking at the ttl of the key, which is what most people expect, see issue: nestjs/throttler#2208
As
blockDuration
must be passed to the increment method, this is the only way that comes to my mind to implement dynamic expiry without making a breaking change (by passing-1
or another negative value as blockDuration, which doesn't make sense anyway)What do you think? Should we make this explicit in throttler, which might require a breaking change, or would this be acceptable in this lib if we document it properly?