Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic expire #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gurgunday
Copy link

@gurgunday gurgunday commented Feb 10, 2025

This is to gather feedback, I really think an auto expire is missing from throttler: other rate limits like fastify-rate-limit automatically calculate the blockDuration by looking at the ttl of the key, which is what most people expect, see issue: nestjs/throttler#2208

As blockDuration must be passed to the increment method, this is the only way that comes to my mind to implement dynamic expiry without making a breaking change (by passing -1 or another negative value as blockDuration, which doesn't make sense anyway)

What do you think? Should we make this explicit in throttler, which might require a breaking change, or would this be acceptable in this lib if we document it properly?

Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: fd0bda7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant