Skip to content

Commit

Permalink
Fix tfjob test; the simple tfjob test prototype was renamed.
Browse files Browse the repository at this point in the history
* kubeflow/trainer#749 renamed the prototype
* ksonnet just fails silently if the component doesn't exist so the test just ends up failing with 404 trying to wait for the job.
* Fix 1266
  • Loading branch information
jlewi committed Jul 25, 2018
1 parent 177377f commit bb7aeab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion testing/workflows/components/workflows.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
"--project=" + project,
"--app_dir=" + tfOperatorRoot + "/test/workflows",
"--tfjob_version=v1alpha1",
"--component=simple_tfjob",
"--component=simple_tfjob_v1alpha2",
// Name is used for the test case name so it should be unique across
// all E2E tests.
"--params=name=simple-tfjob-" + platform + ",namespace=" + stepsNamespace + ",apiVersion=kubeflow.org/" + "v1alpha1" + ",image=" + "gcr.io/tf-on-k8s-dogfood/tf_sample:dc944ff",
Expand Down

0 comments on commit bb7aeab

Please sign in to comment.