Do not fail Assimp build from source if warnings are emitted #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different compilers may emit different warnings when building Assimp. While it's good for the upstream Assimp project to try to minimize warnings by failing a build on a compiler warning by default, for us it creates unnecessary failure modes that are very likely to be caught upstream anyway. For example, GCC 13 as shipped on the latest Ubuntu release has an alleged compiler bug that triggers a warning, and thus fails the Assimp build, even though end-user functionality is not affected. Let's define the CMake variable documented upstream to not treat warnings as errors, which should increase the resilience of our build from source process. Users interested in fixing the root cause of the warnings can contribute to assimp itself.
|
thanks again man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different compilers may emit different warnings when building Assimp. While it's good for the upstream Assimp project to try to minimize warnings by failing a build on a compiler warning by default, for us it creates unnecessary failure modes that are very likely to be caught upstream anyway. For example, GCC 13 as shipped on the latest Ubuntu release has an alleged compiler bug that triggers a warning, and thus fails the Assimp build, even though end-user functionality is not affected.
Let's define the CMake variable documented upstream to not treat warnings as errors, which should increase the resilience of our build from source process. Users interested in fixing the root cause of the warnings can still contribute to Assimp itself.