feat: add @forbidExtraArgs decorator #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kevinhinterlong
commented
Oct 22, 2021
- throws error if unknown arguments are passed (e.g. no corresponding @arg in component)
- only extend class in debug mode
- update docs for @forbidExtraArgs
- throws error if unknown arguments are passed (e.g. no corresponding @arg in component) - only extend class in debug mode - update docs for @@forbidExtraArgs
added 2 commits
October 22, 2021 22:46
- better testing
jkusa
reviewed
Nov 3, 2021
addon/-private/closest-string.ts
Outdated
| @@ -0,0 +1,54 @@ | |||
| // https://stackoverflow.com/a/36566052 | |||
| function editDistance(s1: string, s2: string) { | |||
There was a problem hiding this comment.
I wonder if we can prune this from prod build.
There was a problem hiding this comment.
I was able to remove the code, but not the module from the prod build using @embroider/macros.
Here's the stats of npm ci && ember build --environment="production"
9dfb367 (origin/main)
dist/assets/vendor-cc4233d3b7e5776c9b844d7c3d4ad987.js: 453.59 KB (127.62 KB gzipped)
0ead844
dist/assets/vendor-745ebb22057b189d3eb1f47842a4565d.js: 455.02 KB (128.07 KB gzipped)
a3cd41a
dist/assets/vendor-c13bd7dc8daa2fed4b29e9042c69bd03.js: 454.52 KB (127.82 KB gzipped)
There was a problem hiding this comment.
👍 this is how prop-types does it too. https://github.com/jkusa/ember-arg-types#production
|
Closing then opening to trigger build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.