Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm secret syntax in terraform example #498

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

iamhsa
Copy link
Contributor

@iamhsa iamhsa commented Feb 24, 2025

What this PR does / why we need it: The code in the terraform example has a bad argument in the helm secret call. This PR corrects it.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #497

Special notes for your reviewer: I haven't modify the Changelog.md has it's just a small modification in an example.
Let me know if you think it's necessary.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • I haven't modify the Changelog.md has it's just a small modification in an example.
    Let me know if you think it's necessary.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (036be0e) to head (2a94aed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files          22       22           
  Lines         842      842           
=======================================
  Hits          736      736           
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamhsa iamhsa mentioned this pull request Feb 24, 2025
Copy link
Owner

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkroepke jkroepke merged commit 60685d1 into jkroepke:main Feb 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform example failed
2 participants