Fix visibility and resource weirdness.

jkoritzinsky · May 18, 2021 · a31ac5f · a31ac5f
1 parent 458ccab
commit a31ac5f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/DllImportGenerator/DllImportGenerator/DllImportGenerator.csproj b/DllImportGenerator/DllImportGenerator/DllImportGenerator.csproj
@@ -28,8 +28,9 @@
   </ItemGroup>
 
   <ItemGroup>
-    <Compile Include="../Microsoft.Interop.SourceGeneration/**/*.cs"
-      Link="Microsoft.Interop.SourceGeneration/%(RecursiveDir)%(FileName)%(Extension)" />
+    <Compile Include="../Microsoft.Interop.SourceGeneration/**/*.cs" Link="Microsoft.Interop.SourceGeneration/%(RecursiveDir)%(FileName)%(Extension)" />
+    <EmbeddedResource Include="../Microsoft.Interop.SourceGeneration/Resources.resx" Link="Microsoft.Interop.SourceGeneration/Resources.resx"
+                      LogicalName="Microsoft.Interop.SourceGeneration.Resources.resources" />
   </ItemGroup>
 
   <ItemGroup>
@@ -44,6 +45,7 @@
     <EmbeddedResource Update="Resources.resx">
       <Generator>ResXFileCodeGenerator</Generator>
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
+      <LogicalName>Microsoft.Interop.Resources.resources</LogicalName>
     </EmbeddedResource>
   </ItemGroup>
 </Project>
diff --git a/DllImportGenerator/DllImportGenerator/GeneratorDiagnostics.cs b/DllImportGenerator/DllImportGenerator/GeneratorDiagnostics.cs
@@ -10,7 +10,7 @@ namespace Microsoft.Interop
     /// <summary>
     /// Class for reporting diagnostics in the DLL import generator
     /// </summary>
-    internal class GeneratorDiagnostics : IGeneratorDiagnostics
+    public class GeneratorDiagnostics : IGeneratorDiagnostics
     {
         public class Ids
         {
@@ -153,7 +153,7 @@ public void ReportConfigurationNotSupported(
         /// <param name="method">Method with the parameter/return</param>
         /// <param name="info">Type info for the parameter/return</param>
         /// <param name="notSupportedDetails">[Optional] Specific reason for lack of support</param>
-        public void ReportMarshallingNotSupported(
+        void IGeneratorDiagnostics.ReportMarshallingNotSupported(
             IMethodSymbol method,
             TypePositionInfo info,
             string? notSupportedDetails)

diff --git a/...ortGenerator/Microsoft.Interop.SourceGeneration/Microsoft.Interop.SourceGeneration.csproj b/...ortGenerator/Microsoft.Interop.SourceGeneration/Microsoft.Interop.SourceGeneration.csproj
@@ -23,7 +23,6 @@
       <SubType>Designer</SubType>
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
       <Generator>ResXFileCodeGenerator</Generator>
-      <TypeName>Microsoft.Interop.SourceGenerationResources</TypeName>
     </EmbeddedResource>
     <Compile Update="@(Compile)" Pack="true" />
     <EmbeddedResource Update="@(EmbeddedResource)" Pack="true" />