Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete cookie header to avoid duplicates of cookies #23

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: delete cookie header to avoid duplicates of cookies #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ async function fetch(cookieJars, url, options) {
// or, if headers is an object, construct a Headers object from it
options.headers = new Headers(options.headers);
if (cookies) {
if (options.headers.has("cookie"))
throw new Error(
"options.headers already contains a cookie header!"
);
options.headers.append("cookie", cookies.slice(0, -2));
}
if (wantFollow) options.redirect = "manual";
Expand Down Expand Up @@ -93,6 +97,8 @@ async function fetch(cookieJars, url, options) {
}
const location = result.headers.get("location");
options.redirect = "follow";
// delete cookie header from previous request to avoid a duplicate cookie header
options.headers.delete("cookie");
return fetch(cookieJars, location, options);
}
return result;
Expand Down