Distinguish between logging to stderr and ad-hoc printing to stdout #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update jk/v8worker2 to get jkcfg/v8worker2#4, which prints stacktraces etc., to stderr rather than stdout. 2. it also introduces V8Worker2.log, which prints to stderr; use that in our error handler, so that those error traces go to stderr too.
This changes `std.log` so that it uses `V8Worker2.log`, and thereby
outputs to stderr.
Before log was subordinated to the role of logging, it was used
extensively to print simple results to stdout, for testing and
whatnot.
The need for printing to stdout is common; so rather than rewrite
everything to use
write(val, '', opts)
this also adds a `print` procedure which can be used instead.
b4a732a to
4583570
Compare
|
Note to self: I should now spend some time putting tests in to make sure things go to stderr v stdout! |
|
For the record: one concern is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims:
This PR:
std.logoutput to stderr, by using (the new method)V8Worker2.logstd.printwhich fills much the same purpose asstd.logdid -- it's a casual way to output valuesAside from outputting to stderr,
std.logbehaves a bit differently, since it doesn't go throughwrite. There's no formatting options -- strings get printed as-is, and anything else goes throughJSON.stringify(which by default, keeps everything on one line). This is better suited to logging output, I reckon.An alternative would be to keep
std.logas it is, and give people another procedure for printing to stderr. I felt thatlogstrongly suggests logging output, which comes with the expectation of output to stderr, and it was better to correct that now than have to keep explaining it.