-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screening Sharing Not Getting Above 5 FPS #2298
Comments
For desktop share the content hint should stay as detail, if set to motion it degrades the quality significantly that its hard to read text on desktop shares. |
Ping @jallamsetty1 |
I agree with @ProdigyView that we should set the contentHint to 'motion' when the captured fps > 5. I am working on fixing this. For low fps screenshare, we set the contentHint to 'detail' and send only the highest spatial resolution and for high fps screenshare we need to set the contentHInt to 'motion' and send all the spatial-temporal layers so that the jvb can pick the best spatial-temporal layer based on the receivers BWE. |
…ectly. contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
…ectly. contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
…ectly. contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
…ectly. contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes #2298.
I am re-opening the issue presented here:
#1089
But also the issue isn't just with Jitsi but a bug with Chrome as presented here:
https://bugs.chromium.org/p/webrtc/issues/detail?id=13016
The fix in the above was to set contentHint to motion. In Jitsi, I accomplished this will the following:
The section of the code that was changed was this: https://github.com/jitsi/lib-jitsi-meet/blob/9db908a3658c05674f48e8dd356ceafe8bb5fa88/JitsiMeetJS.ts#LL336C16-L336C16
But it seems to be still be capped at 5 fps. Any thoughts?
The text was updated successfully, but these errors were encountered: