Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screening Sharing Not Getting Above 5 FPS #2298

Closed
ProdigyView opened this issue Jun 21, 2023 · 3 comments · Fixed by #2304
Closed

Screening Sharing Not Getting Above 5 FPS #2298

ProdigyView opened this issue Jun 21, 2023 · 3 comments · Fixed by #2304

Comments

@ProdigyView
Copy link

I am re-opening the issue presented here:

#1089

But also the issue isn't just with Jitsi but a bug with Chrome as presented here:

https://bugs.chromium.org/p/webrtc/issues/detail?id=13016

The fix in the above was to set contentHint to motion. In Jitsi, I accomplished this will the following:

for (const track of tracks) {
                    
                    if (track.type === MediaType.VIDEO
                        && track.videoType === 'desktop') {
                        this.setVideoTrackContentHints(track.track, 'motion');
                    }
                }

The section of the code that was changed was this: https://github.com/jitsi/lib-jitsi-meet/blob/9db908a3658c05674f48e8dd356ceafe8bb5fa88/JitsiMeetJS.ts#LL336C16-L336C16

But it seems to be still be capped at 5 fps. Any thoughts?

@DanielMcAssey
Copy link
Contributor

For desktop share the content hint should stay as detail, if set to motion it degrades the quality significantly that its hard to read text on desktop shares.

@saghul
Copy link
Member

saghul commented Jun 26, 2023

Ping @jallamsetty1

@jallamsetty1
Copy link
Member

I agree with @ProdigyView that we should set the contentHint to 'motion' when the captured fps > 5. I am working on fixing this. For low fps screenshare, we set the contentHint to 'detail' and send only the highest spatial resolution and for high fps screenshare we need to set the contentHInt to 'motion' and send all the spatial-temporal layers so that the jvb can pick the best spatial-temporal layer based on the receivers BWE.

jallamsetty1 added a commit to jallamsetty1/lib-jitsi-meet that referenced this issue Jun 27, 2023
…ectly.

contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
jallamsetty1 added a commit to jallamsetty1/lib-jitsi-meet that referenced this issue Jun 28, 2023
…ectly.

contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
jallamsetty1 added a commit to jallamsetty1/lib-jitsi-meet that referenced this issue Jun 28, 2023
…ectly.

contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
jallamsetty1 added a commit that referenced this issue Jun 28, 2023
…ectly.

contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes #2298.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants