Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MultiStreamConfig, always enable multi-stream mode. #1948

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Sep 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1948 (1bd6f07) into master (a22f308) will decrease coverage by 0.31%.
The diff coverage is 44.35%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1948      +/-   ##
============================================
- Coverage     41.60%   41.29%   -0.32%     
+ Complexity     1757     1661      -96     
============================================
  Files           338      336       -2     
  Lines         17824    17531     -293     
  Branches       2388     2303      -85     
============================================
- Hits           7416     7239     -177     
+ Misses         9670     9588      -82     
+ Partials        738      704      -34     
Impacted Files Coverage Δ
...rg/jitsi/videobridge/EndpointMessageTransport.java 9.63% <0.00%> (-3.85%) ⬇️
...n/java/org/jitsi/videobridge/shim/ChannelShim.java 0.00% <0.00%> (ø)
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 21.17% <0.00%> (+0.49%) ⬆️
...i/videobridge/cc/allocation/BandwidthAllocation.kt 87.23% <0.00%> (-2.57%) ⬇️
...c/main/kotlin/org/jitsi/videobridge/relay/Relay.kt 18.43% <0.00%> (+0.03%) ⬆️
...g/jitsi/videobridge/relay/RelayMessageTransport.kt 9.09% <0.00%> (+0.98%) ⬆️
...lin/org/jitsi/videobridge/relay/RelayedEndpoint.kt 0.00% <0.00%> (ø)
...n/java/org/jitsi/videobridge/AbstractEndpoint.java 27.27% <29.41%> (+3.10%) ⬆️
...org/jitsi/videobridge/xmpp/MediaSourceFactory.java 83.41% <50.00%> (-0.09%) ⬇️
...tsi/videobridge/cc/allocation/BitrateController.kt 55.07% <50.00%> (+0.90%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22f308...1bd6f07. Read the comment docs.

@JonathanLennox
Copy link
Member

Can "SingleSourceAllocation2", "prioritize2", "BitrateAllocationNewTest", etc., get their names changed now?

@JonathanLennox
Copy link
Member

The other change I'd make is removing the "New" from "BitrateControllerNewTest" and "EffectiveConstraintsNewTest"; otherwise seems good.

@bgrozev bgrozev merged commit ce94dbb into jitsi:master Sep 15, 2022
@bgrozev bgrozev deleted the remove-non-multi-stream branch May 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants