Add config option for ICE nomination strategy. #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
reviewed
Apr 7, 2020
| @@ -135,7 +135,7 @@ | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <artifactId>ice4j</artifactId> | |||
| <version>3.0-1-ge854e4e</version> | |||
| <version>3.0-10-g982e782</version> | |||
There was a problem hiding this comment.
Any other changes in this version bump we should be worried about?
There was a problem hiding this comment.
Reviewing them I think they're all desirable or harmless.
bbaldino
approved these changes
Apr 7, 2020
|
I think this will need jitsi/jicofo#460 to be merged first or we'll start getting PR testing failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jitsi/ice4j#197.